mapbox / mapbox/node-pre-gyp

Support a property "download-host" in binary object

Open
#153 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.2k
Forks
271
Avg merge
23h 40m
Merged PRs (30d)
2

Description

Node-pre-gyp support publish binaries to Amazon S3, But China Firewall(GFW) has blocked visit Amazon S3,Chinese download a tarball binary is difficult.

So, Can we add a property 'download-host' in binary object, using the property when download tarball binaries?

if download-host is undefined, just use host property.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating how the binary object is read and where tarball downloads choose the host. Trace the existing host behavior, then verify that an optional download-host is used for downloads and that an undefined value falls back to host; done means this behavior is covered by appropriate tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.