mapbox / mapbox/node-or-tools

`ACTION binding_gyp_action_before_build_target_install_deps mason_packages` is called twice on Node 10

Open
#59 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
155
Forks
47
PR merge metrics
No merged PRs in 30d

Description

This is very weird as it only happens if node_or_tools is part of a package.json with other packages, but it doesn't happen if node_or_tools is the only package in the package.json file.

Node version is v10.11.0

node-pre-gyp WARN Using request for node-pre-gyp https download 
node-pre-gyp WARN Tried to download(403): https://mapbox-node-binary.s3.amazonaws.com/node_or_tools/v1.0.6/Release/node-v64-darwin-x64.tar.gz 
node-pre-gyp WARN Pre-built binaries not found for node_or_tools@1.0.6 and node@10.11.0 (node-v64 ABI, unknown) (falling back to source compile with node-gyp) 
node-pre-gyp WARN Pre-built binaries not installable for node_or_tools@1.0.6 and node@10.11.0 (node-v64 ABI, unknown) (falling back to source compile with node-gyp) 
node-pre-gyp WARN Hit error Connection closed while downloading tarball file 
  ACTION binding_gyp_action_before_build_target_install_deps mason_packages
  ACTION binding_gyp_action_before_build_target_install_deps mason_packages
Downloading Mason @ca9b4cb
Downloading Mason @ca9b4cb
* Downloading binary package osx-x86_64/protobuf/3.0.0.tar.gz...
* Downloading binary package osx-x86_64/protobuf/3.0.0.tar.gz...
* Installed binary package at /xxx/node_modules/node_or_tools/mason_packages/osx-x86_64/protobuf/3.0.0
* Linking /xxx/node_modules/node_or_tools/mason_packages/osx-x86_64/protobuf/3.0.0
* Links will be inside /xxx/node_modules/node_or_tools/mason_packages/.link/
* Using bash fallback for symlinking (install lndir for faster symlinking)
mv: cannot stat '/xxx/node_modules/node_or_tools/mason_packages/.binaries/osx-x86_64/protobuf/3.0.0.tar.gz.tmp': No such file or directory

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the install with node_or_tools alone and alongside other packages in package.json on Node v10.11.0, then inspect the node-pre-gyp/node-gyp build path around the repeated binding_gyp_action_before_build_target_install_deps action. Done means the action runs once and the Mason protobuf package installs without the missing temporary-file error.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, node.js
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.