mapbox / mapbox/node-fontnik

Re-enable clang-tidy checks

Open
#169 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

jira-sync-complete
Dominant language
C++
Stars
248
Forks
67
PR merge metrics
No merged PRs in 30d

Description

In #163 I disabled the clang-tidy checks because we're planning to port to Napi soon and that will likely fix many of the clang-tidy warnings.

So, let's plan to re-enable after Napi lands.

/cc @artemp

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue #163 and checking how clang-tidy was disabled in the repository. Confirm whether the planned Napi port has landed, then identify the disabled checks and re-enable them; done means the checks run successfully without unresolved warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.