mapbox / mapbox/node-fontnik

Cannot render gift-24 icon from Maki v1

Open
#147 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

jira-sync-complete
Dominant language
C++
Stars
248
Forks
67
PR merge metrics
No merged PRs in 30d

Description

It seems that node-fontnik cannot parse or render one particular icon, the gift-24 SVG from Maki v1.

I'm creating PBF from SVGs using an IcoMoon font. In my selection of cca. 60 icons every other SVG worked flawlessly, except this one.

It's probably possible to manually fix the SVG, I just wanted to report this.

IcoMoon minimal reproducible case JSON:
https://www.dropbox.com/s/njdzd5mhpuqzbrq/fontnik-bug.json?dl=0

Generated TTF:
https://www.dropbox.com/s/wjppjd18gd34p90/fontnik-bug.ttf?dl=0

gift-24 source:
https://github.com/mapbox/maki/blob/v0.5.0/src/gift-24.svg?short_path=75aded5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure with the linked IcoMoon minimal-case JSON and generated TTF, then compare gift-24.svg from Maki v1 with the other SVGs that render successfully. Trace the node-fontnik conversion path for this input; done means the gift-24 glyph can be converted to PBF and rendered like the other icons.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, node.js
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.