mapbox / mapbox/node-fontnik

Should not return empty PBFs if no glyphs found in range

Open
#126 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

jira-sync-complete
Dominant language
C++
Stars
248
Forks
67
PR merge metrics
No merged PRs in 30d

Description

I believe creating empty PBFs was originally intentional to make sure these ranges all existed on S3, but we should consider revisiting this in a v3 version of the `/glyphs` S3 API.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the /glyphs S3 API behavior described in the issue, especially how ranges with no glyphs are handled. Determine the intended v3 contract for empty PBFs and confirm what tests or API documentation should define the change as complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
api, computer-graphics
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.