Avoiding hardcoded build options
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 74
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
Currently in order to build on Ubuntu Linux (18.04) using either system g++7 or source compiled clang++7 I had to apply following patch:
CXX=/usr/bin/g++ make
diff --git a/common.gypi b/common.gypi
index 803f217..6ae5c84 100644
--- a/common.gypi
+++ b/common.gypi
@@ -38,11 +38,8 @@
'NDEBUG'
],
'cflags': [
- '-flto'
],
'ldflags': [
- '-flto',
- '-fuse-ld=<(module_root_dir)/mason_packages/.link/bin/ld'
],
'xcode_settings': {
'OTHER_CPLUSPLUSFLAGS!': [
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect common.gypi and the build invocation shown in the issue, then reproduce the Ubuntu build with system g++7 or source-built clang++7. Done means the project builds without manually removing the hardcoded -flto flags and mason linker path from common.gypi.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, node.js
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100