mapbox / mapbox/node-cpp-skel

Add make testpack

Open
#113 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue
Dominant language
C++
Stars
74
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Per convo with @flippmoke, I learned about make testpack which is used in node-mapnik to ensure the final package looks good to officially publish and to avoid dependency issues later in the chain.

Would be great for skel to have a workflow in place for ensuring the final package contains everything we'd expect, for example node_modules/node-pre-gyp/

cc @springmeyer @millzpaugh @mapsam

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the referenced node-mapnik Makefile's make testpack target and comparing it with this repository's packaging workflow. Define the expected final package contents, including node_modules/node-pre-gyp, and verify the workflow catches missing dependencies before publication.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, node.js
Domain
build-system, release
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.