mapbox / mapbox/nodata

Separate IO logic from processing logic

Open
#72 0 comments 0 reactions 1 assignee View on GitHub

@dnomadb is already working on this.

Since Jun 5, 2018.

Dominant language
Python
Stars
1
Forks
2
PR merge metrics
No merged PRs in 30d

Description

https://github.com/mapbox/nodata/blob/fa5fd9354ae1e301c39557fd5562071f8ad546e7/nodata/blob.py#L58

We currently have a large about of reads / writes interspersed into a function where processing paths are:

1. Decided via nested ifs/thens; and
2. Combined with working logic, eg https://github.com/mapbox/nodata/blob/fa5fd9354ae1e301c39557fd5562071f8ad546e7/nodata/blob.py#L73-L75

We should try to separate these out as much as possible.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.