mapbox / mapbox/nodata

skippy logic revisited

Open
#55 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

wontfix
Dominant language
Python
Stars
1
Forks
2
PR merge metrics
No merged PRs in 30d

Description

We test a fully padded mask and this has implications as to whether we want to runNodataFiller

+-----------+
|  outside  |
| +-------+ |
| | inside| |
| |       | |
| +-------+ |
|           |
+-----------+

Each of the regions can be one of three things: all_nodata, all_data, some_nodata so the logic might look like this:

Outside
All nodata Some nodata All data
All nodata skip run run
Inside Some nodata run (edit) run run
All data skip skip skip

@dnomadb does that sound right?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the runNodataFiller entry point and reviewing how fully padded masks represent the outside and inside regions. Use the issue's region-state table to clarify the intended behavior, then add or update coverage for the relevant combinations. Done means the behavior for each listed state combination is agreed and tested.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.