mapbox / mapbox/nepomuk

Suppress OnRoute transfers

Open
#72 0 comments 0 reactions 0 assignees View on GitHub
Feature Request
Dominant language
C++
Stars
24
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Splitting out from https://github.com/mapbox/directions-transit/issues/66:

When a trip contains an OnRoute transfer, we currently would issue a new leg for this trip, since the line changes. In reality, we stay on the same line, though. We should suppress these types of transfers in our output, as it exposes internals right now, which should be hidden from the user.

Tasks:

- [ ] add a test fixture that contains an actual loop in the middle
- [ ] implement suppression of on-route transfers

Contributor guide

Open the contributing guide

Research direction

Start by inspecting the transfer-output code and existing test fixtures in the nepomuk repository, then find how OnRoute transfers are represented for a trip. Add a fixture containing an actual loop in the middle and verify that OnRoute transfers are suppressed while ordinary line-changing transfers remain visible.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.