Test GTFS parsing
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 24
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/mapbox/directions-transit/pull/6 does not perform full testing of the GTFS format. While nearly the complete set of possible code paths is taken, the results are currently mostly ignored.
We should improve the testing in [import-csv.cc](https://github.com/mapbox/directions-transit/pull/6/files#diff-30789bcf7af83dd09f0f0ba5f65fbe3b) to actually check the created fixtures (see [here](https://github.com/mapbox/directions-transit/pull/6/files#diff-30789bcf7af83dd09f0f0ba5f65fbe3bR48)) for an example).
This will ensure that our csv parsing is actually working as expected.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with import-csv.cc and the example around line 48 in the referenced pull request. Review how the GTFS fixtures are created, then add assertions that check their parsed results rather than ignoring them. Done means the tests validate the expected CSV parsing behavior across the exercised GTFS code paths.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100