Button as child of .prose has blue text
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 90
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
When Button uses an a element and is a child of .prose, its text shows up as blue on blue. We got around this by passing in passthroughProps with all of the same classes the Button component would use but with unprose added, but this defeats the purpose of using the component.
There were two instances of using this in the help docs, I am not sure if there are others throughout the other docs sites.
It's also possible there's an easier fix I am not aware of, just leaving this here in case we should account for this in mr-ui
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Button component and its anchor rendering, then inspect the two help docs instances that place it inside .prose. Reproduce the blue-on-blue text case and verify that Button styling remains correct without passthroughProps or an added unprose class. Check the other docs sites for similar uses.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100