Dark theme for Modal
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 90
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
The color of the close icon is always blue, but sometimes I wish it could be white. Example:
A couple ideas come to mind:
- Add a dark theme (example: `theme='dark'` which would set the close icon to `color-white` and the background of the modal to `bg-dark-gray`. But you could still customize by turning off the padding like in the example above.
- Add option to change color of close icon - solve the root problem.
Opinions?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the Modal component and its existing styling to find how the close icon color and modal background are defined. Compare the proposed dark theme with the alternative customizable icon color, then establish which behavior maintainers want before changing anything; done means the selected option is implemented and its appearance is verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- design, frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100