mapbox / mapbox/mason

Boost libs: cflags + ldflags should be empty

Open
#83 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
258
Forks
68
PR merge metrics
No merged PRs in 30d

Description

The compiled boost libs are static libs, so the user should use static_libs to obtain the paths. However, calling cflags and ldflags on them currently either fails, or returns -lboost_*, which may cause failure since it doesn't specify the path to the library also.

We should mass-apply this patch to all compiled boost libs:

diff --git a/script.sh b/script.sh
index b2eb041..e5562b2 100755
--- a/script.sh
+++ b/script.sh
@@ -58,8 +58,12 @@ function mason_compile {
     mv stage/${MASON_LIB_FILE} ${MASON_PREFIX}/${MASON_LIB_FILE}
 }

+function mason_cflags {
+    : # Use the boost headers package
+}
+
 function mason_ldflags {
-    echo "-lboost_${BOOST_LIBRARY}"
+    : # We're only using the full path to the archive, which is output in static_libs
 }

 function mason_clean {

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the compiled Boost library package scripts and their script.sh files. Inspect mason_cflags, mason_ldflags, and mason_compile, then apply the requested behavior across the compiled Boost libraries. Done means cflags and ldflags are empty while static_libs provides the archive paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.