mapbox / mapbox/mason

test coverage for source compile fallback

Open
#74 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
258
Forks
68
PR merge metrics
No merged PRs in 30d

Description

In the future we might change mason so that the `install` step does not fallback to a source compile if a binary does not exist (#71). But until then we should make sure to add test coverage for this case. I think we're missing test coverage since this temporarily regressed (and was fixed in https://github.com/mapbox/mason/commit/c43967404c84d020d63f6aba450d97770dfeaebb)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing Mason's install step and reviewing the regression fix in commit c43967404c84d020d63f6aba450d97770dfeaebb. Add test coverage for the case where no binary exists and installation falls back to compiling from source; done when that fallback behavior is exercised by a test.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.