mapbox / mapbox/mason

Detect between gitsha and tag

Open
#578 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
258
Forks
68
PR merge metrics
No merged PRs in 30d

Description

When creating a new mason release PR, there is a tricky difference in the `mason_load_source`
function between [gitsha releases](https://github.com/mapbox/mason/blob/master/scripts/vtzero/088ec09/script.sh#L11) and official [tag releases](https://github.com/mapbox/mason/blob/master/scripts/protozero/1.6.1/script.sh#L11).

Similar gotchya related to the [build path](https://github.com/mapbox/mason/blob/master/scripts/vtzero/088ec09/script.sh#L16)

- gitsha --> `mason_packages/.build/mapbox-vtzero-7adde32`
- tag--> `mason_packages/.build/vtzero-1.0.0`

How can mason perhaps detect this automatically? Or somehow avoid this unknown gotchya?

cc @mapbox/core-tech

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare mason_load_source and the build paths in scripts/vtzero/088ec09/script.sh and scripts/protozero/1.6.1/script.sh. Trace how gitsha and tag releases produce their package paths, then define how Mason should detect or avoid the difference; done means the release flow no longer depends on this hidden distinction.

Written by the indexing model from the issue text.

Assessment

Tech stack
git
Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.