Use -isystem to pass include paths
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 258
- Forks
- 68
- PR merge metrics
- No merged PRs in 30d
Description
We are currently using `-I` to pass the paths to Mason packages to the compiler. However, we should be using `-isystem` to prevent warning messages from this third party code.
In CMake, simply adding `SYSTEM` to [`target_include_directories`](https://cmake.org/cmake/help/v3.7/command/target_include_directories.html) suffices. Unfortunately, the Xcode generator [doesn't support this yet](https://gitlab.kitware.com/cmake/cmake/issues/16795). This means there are no next actions here until this is fixed in CMake and deployed widely enough in a few years^H^H^Hdecades
/cc @springmeyer
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the issue's target_include_directories reference and the linked CMake issue about Xcode generator support. Confirm whether the required CMake support is available in deployed versions. Done means Mason package include paths are passed with -isystem without breaking supported generators.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 20/100