mapbox / mapbox/mason

Maintaining boost cxx11abi packages

Open
#319 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

ng
Dominant language
Python
Stars
258
Forks
68
PR merge metrics
No merged PRs in 30d

Description

@tmpsantos (in https://github.com/mapbox/mason/pull/268) has figured out how to build cxx11abi packages for boost libraries on travis 🎉 .

The key is that we need to edit the headers of the libstdc++ installed to enable the "duel API":

```bash
sudo perl -i -p -e "s/# define _GLIBCXX_USE_DUAL_ABI 0/# define _GLIBCXX_USE_DUAL_ABI 1/g;" /usr/include/x86_64-linux-gnu/c++/5/bits/c++config.h
```

per https://github.com/mapbox/mason/issues/157#issuecomment-272378928

Then one can set `-D_GLIBCXX_USE_CXX11_ABI=1` and it is respected and will no longer default to `0`.

Now we need to think through how to keep these maintained.

TODO:

- [ ] Does the boost new release script work?
https://github.com/mapbox/mason/blob/master/utils/new_boost.sh
- [ ] Other existing cxx11abi packages need be ported to be built on travis (rather than manually pushed) (notably gtest - refs https://github.com/mapbox/mason/pull/209)
- [ ] Do we want to maintain cxx11abi packages for all boost libraries?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with utils/new_boost.sh and the Travis build approach described in the issue. Check whether the Boost release script works for cxx11abi packages, then review the existing gtest package and mapbox/mason#209 for the porting pattern. Done means deciding the Boost coverage and moving the relevant existing packages from manual publishing to Travis builds.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, devops
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.