mapbox / mapbox/mason

include paths: -I vs -isystem

Open
#261 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
258
Forks
68
PR merge metrics
No merged PRs in 30d

Description

I'm seeing many custom packages that specify the same path both in `-I` and `-isystem`. Is there a particular reason to do that?

In https://github.com/mapbox/mason/blob/master/mason.sh#L496, we are removing the prefix from there and call `uniq` to remove adjacent duplicates.

/cc @springmeyer @artemp

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading mason.sh around line 496 and trace how -I and -isystem include paths are normalized and deduplicated. Consult the relevant compiler behavior, then determine whether removing the prefix and adjacent duplicates is correct and what change or clarification the issue requires.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, shell
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.