mapbox / mapbox/mason

Put -DNDEBUG in compile flags

Open
#126 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
258
Forks
68
PR merge metrics
No merged PRs in 30d

Description

Libraries like harfbuzz do not put `-DNDEBUG` in the compiler flags by defaults, which leaves `assert` live. For release builds we should ensure `asserts` are removed for best perf. Instead of adding per package I think this should be global. Not a high priority so just ticketing for later.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating Mason's global handling of compiler flags and release-build configuration; the issue does not name a file or test. Verify how package builds currently set flags, then confirm that release builds consistently pass -DNDEBUG without requiring per-package changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.