mapbox / mapbox/mason

On OS X, failing to install pkg-config results in a broken build with no obvious error

Open
#112 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
258
Forks
68
PR merge metrics
No merged PRs in 30d

Description

@ljbade

On OS X, if pkg-config is not installed before building a mason project, e.g. mapbox-gl-native for android, then the build will semi-silently fail to do the pkg-config step but proceed on to a broken build (as evidenced by errors such as not finding the headers for mason packages).

https://gist.github.com/adam-mapbox/d7202588aec6ad7c4b0b

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the build on OS X without pkg-config, using the mason project example described in the issue. Inspect the pkg-config step and its handling of failure; done means the missing dependency produces an obvious error instead of continuing to a broken build.

Written by the indexing model from the issue text.

Assessment

Tech stack
macos
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.