mapbox / mapbox/mapping

[Germany] Reviewing osmlint-osmium and osmlint data issues

Open
#364 11 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
254
Forks
46
PR merge metrics
No merged PRs in 30d

Description

### Intro
Our team extracted data from OSM for Germany, and checked it via [osmlint-osmium](https://github.com/osmlab/osmlint-osmium) and [osmlint](https://github.com/osmlab/osmlint). We found 25k+ issues to review and resolve. The output of all the linters can be found [here](https://github.com/mapbox/mapping/files/5336129/germany.1.zip).
[Link](https://wiki.openstreetmap.org/wiki/Organised_Editing/Activities/resolve_linting_issues_in_Germany) to the OSM wiki page.

We are planning to review all the detections and help resolve the issues on existing data in OSM. We welcome help in fixing these issue -- ping us with any updates.

### Timeframe

We are going to start addressing issues identified by the linters on October 12. Based on past experience, we expect about 1500 of the 25 473 issues detected in Germany to be resolved.

### Tools

During our work we are going to use standard OSM tools for editing: iD and JOSM editors; Bing, Maxar, Esri satellites data; and Mapillary street level images and other open sources that are compliant with OSM.

### Contact person

If you have a question about a specific edit, please comment in the changeset, message the mapper who did it, or email Natallia (natallia.zhouner@mapbox.com) as the manager of the project.

### Used hashtag

**#mbx_germany_roads** is the unique hashtag for the changeset comments.

### Linter output

issue | Germany| Files
--|--:|--:
crossinghighways | 8678 | [crossinghighways.zip](https://github.com/mapbox/mapping/files/5336080/crossinghighways.zip)
crossinghighwaysbridges | 19 | [crossinghighwaysbridges.zip](https://github.com/mapbox/mapping/files/5336088/crossinghighwaysbridges.zip)
crossinghighwaysbuildings | 11691 | [crossinghighwaysbuildings.zip](https://github.com/mapbox/mapping/files/5336091/crossinghighwaysbuildings.zip)
impossibleangle | 532 | [impossibleangle.zip](https://github.com/mapbox/mapping/files/5336093/impossibleangle.zip)
impossibleoneways | 1899 | [impossibleoneways.zip](https://github.com/mapbox/mapping/files/5336094/impossibleoneways.zip)
islandshighways | 1692 | [islandshighways.zip](https://github.com/mapbox/mapping/files/5336096/islandshighways.zip)
mixedlayer | 89 | [mixedlayer.zip](https://github.com/mapbox/mapping/files/5336099/mixedlayer.zip)
tr-excessiverolestr | 162 | [tr-excessiverolestr.zip](https://github.com/mapbox/mapping/files/5336103/tr-excessiverolestr.zip)
tr-invalidroletr | 64 | [tr-invalidroletr.zip](https://github.com/mapbox/mapping/files/5336105/tr-invalidroletr.zip)
tr-missingroletr | 433 | [tr-missingroletr.zip](https://github.com/mapbox/mapping/files/5336108/tr-missingroletr.zip)
tr-missingtyperestrictiontr | 214 | [tr-missingtyperestrictiontr.zip](https://github.com/mapbox/mapping/files/5336114/tr-missingtyperestrictiontr.zip)

### Here are some examples:

Impossible oneways is one of the 11 categories of linters:

-[here](https://www.openstreetmap.org/edit#map=21.20/51.66561/9.37846) we see two oneways from different direction are meeting in one point

![изображение](https://user-images.githubusercontent.com/60132467/95393007-71dfa980-0902-11eb-80d8-1ed4d71f1f27.png)

There are problems with the connection of roads near polygons, especially parking lots. Parking lots in Germany are often mapped by polygons without lines (roads) inside the polygon and since there are no lines inside the polygon, routing will not work. Such example you can find [here](https://www.openstreetmap.org/edit#map=20.51/52.26011/8.94288)

![изображение](https://user-images.githubusercontent.com/60132467/95393062-989de000-0902-11eb-9c11-6c3ad750a9fe.png)

Also found unconnected service roads. To be routable, they should be connected into the road network. You can find example [here](https://www.openstreetmap.org/edit#map=20.29/51.26242/7.05803)

![изображение](https://user-images.githubusercontent.com/60132467/95393089-a5223880-0902-11eb-9955-4ba053c98038.png)

More examples:
[Unconnected roads 1.](https://www.openstreetmap.org/edit#map=18/51.99680/11.13211)

![изображение](https://user-images.githubusercontent.com/60132467/95393113-af443700-0902-11eb-9c70-e976f575df7f.png)

[Unconnected roads 2.](https://www.openstreetmap.org/edit#map=20.50/51.93975/11.23224)

![изображение](https://user-images.githubusercontent.com/60132467/95393134-bc612600-0902-11eb-9e95-4c7aaacadbdc.png)

### Your comments and questions are welcome here

@legain @Andygol @abrohood @shvrm

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Germany output archive and the category ZIP files linked in the issue, then inspect the examples using iD or JOSM and the referenced OSM tools. Done would mean reviewing applicable detections and resolving valid issues in OSM, but the issue does not define a bounded newcomer-sized subset.

Written by the indexing model from the issue text.

Assessment

Domain
data
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.