mapbox / mapbox/mapbox-vision-ios
Vision SDK should notify delegate when replay video finishes
@chezzdev is already working on this.
Since Sep 17, 2019.
- Dominant language
- Swift
- Stars
- 63
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Description
## Description
VisionReplayManager does not notify the delegate when replay finishes. This presents a problem for the delegate since it will not know if the replay manager state is start or stop.
For example, if I am using the replay manager to replay a nav session in Apex, I need to stop the replay manager if the user hits the "end" button. However, if the replay runs all the way through to the end before the user hits `End`, then if I try to stop the replay then I will crash since the replay manager throws an exception if the replay manager is told to stop when it is not playing.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.