mapbox / mapbox/mapbox-vision-ios
Xcode build phase script improvements
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 63
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Description
## Description
Our build phase has a script for copying frameworks, that script has a room for improvements, for now we noticed. At least:
- use `set -euo pipefail` as a general setup;
- check presence of arguments if it's required;
- add comprehensive comments, because for now it's not clear at first sight what is going on;
- etc.
More useful notes about script improvements can be found in the [pr](https://github.com/mapbox/mapbox-vision-devtools/pull/2).
## Goal
Improve xcode build phase script.
## Steps
- [ ] Improve the script;
- [ ] Tested and acceptance criteria is matched (result matches the goal).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Xcode build phase script and review the additional improvement notes in the referenced pull request. Done means the script has the requested setup, required-argument checks, comprehensive comments, and passes the stated acceptance testing.
Written by the indexing model from the issue text.
Assessment
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100