mapbox / mapbox/mapbox-search-android
Favorite item not persisted between app sessions in SearchPlaceBottomSheetView
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 39
- Forks
- 10
- PR merge metrics
- No merged PRs in 30d
Description
## Favorite item not persisted between app sessions in SearchPlaceBottomSheetView
- Search SDK Component (check at least one)
- [ ] Core Search SDK (`SearchEngine` class, and etc.)
- [ ] Offline Search SDK (`OfflineSearchEngine` class, and etc.)
- [ ] Address Autofill SDK
- [X] Search UI SDK
- Android OS version:
- Devices affected:
- Search SDK Version: 1.0.0-rc.7
- Included in project Maps SDK, Nav SDK versions if available:
Favorited item is not remembered in SearchPlaceBottomSheetView once app restarts, I am sorry but do you guys even test this SDK? Core implementation is solid, but these kind of bugs are surprising.
In the list with results it is marked as favorite, but on bottom sheet not, I can add it again to favorites, even though it is already there.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with SearchPlaceBottomSheetView in the Search UI SDK and reproduce the favorite state before and after an app restart. Trace how the results list and bottom sheet represent the favorited item; done means both views restore the same state and do not allow an already-favorited item to be added again.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile-dev, search
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100