mapbox / mapbox/mapbox-sdk-js

remove commited bundle.js

Open
#383 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
768
Forks
191
PR merge metrics
No merged PRs in 30d

Description

We have a bundle.js committed into the repo https://github.com/mapbox/mapbox-sdk-js/commits/master/bundle.js and it seems this was done to be used with unpkg etc.

However we currently recommend unkpg to use the file from umd/mapbox-sdk.js https://github.com/mapbox/mapbox-sdk-js#pre-bundled-files-on-unpkgcom

Nor is it included in the publish version package https://github.com/mapbox/mapbox-sdk-js/blob/e3574d1749f89ca741206e61a49fc71ad5461d25/package.json#L6-L12

So should we remove it, or add it to the published version package?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the committed bundle.js with the README's pre-bundled unpkg guidance and the package.json publication entries. Confirm whether bundle.js is needed by a supported distribution path, then make the repository and published package consistent by removing or including it and verify the relevant packaging references.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system, release
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.