mapbox / mapbox/mapbox-sdk-js

getMatrix return null value

Open
#312 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
768
Forks
191
PR merge metrics
No merged PRs in 30d

Description

The current master version of getMatrix return matrix which has null value. For the npm version it works fine(all the value are numeric). This is the code:

```
var locations = [
[13.414649963378906, 52.522905940278065],
[13.363409042358397, 52.549218541178455],
[13.394737243652344, 52.55062769982075],
[13.426065444946289, 52.54640008814808],
[13.375682830810547, 52.536534077147714],
[13.39010238647461, 52.546191306649376],
[13.351736068725584, 52.50754964045259],
[13.418254852294922, 52.52927670688215]
];

matrixService.getMatrix({
points: locations.map(function(coord) {
return { coordinates: [coord[0], coord[1]] };
}),
profile: profile
})
.send()
.then(function(response: any) {
// if (response.statusCode !== 200) {
// console.error("MbxClient::getMatrix Error: " + response.statusCode);
// return;
// }

const results: any = response.body;
console.log("MbxClient::getMatrix response.body" + JSON.stringify(results));
});
```
Based on above locations, the response is:
```
[0,null,null,null,24256.1,null,null,19851.3,null,24256.1,24256.1,null,null,null,24256.1,null,null,17502,null,null,null,null,null,null,24256.1
[null,0,41531.5,41531.5,null,43190.2,41531.5,null,7451.1,null,null,7451.1,6595.2,41531.5,null,7451.1,41625.9,null,41531.5,41531.5,41531.5,41531.5,7451.1,41531.5,null
[null,41668.4,0,0,null,4013.8,0,null,37580.5,null,null,37580.5,36724.6,0,null,37580.5,1555.8,null,0,0,0,0,37580.5,0,null
[null,41668.4,0,0,null,4013.8,0,null,37580.5,null,null,37580.5,36724.6,0,null,37580.5,1555.8,null,0,0,0,0,37580.5,0,null
[24252,null,null,null,0,null,null,4404.8,null,0,0,null,null,null,0,null,null,6754.1,null,null,null,null,null,null,0
[null,43182.2,4115.5,4115.5,null,0,4115.5,null,39094.3,null,null,39094.3,38238.4,4115.5,null,39094.3,3767.3,null,4115.5,4115.5,4115.5,4115.5,39094.3,4115.5,null
[null,41668.4,0,0,null,4013.8,0,null,37580.5,null,null,37580.5,36724.6,0,null,37580.5,1555.8,null,0,0,0,0,37580.5,0,null
[19847.2,null,null,null,4404.8,null,null,0,null,4404.8,4404.8,null,null,null,4404.8,null,null,2349.3,null,null,null,null,null,null,4404.8
[null,7544.9,37597.4,37597.4,null,39256.1,37597.4,null,0,null,null,0,1831.7,37597.4,null,0,37691.8,null,37597.4,37597.4,37597.4,37597.4,0,37597.4,null
[24252,null,null,null,0,null,null,4404.8,null,0,0,null,null,null,0,null,null,6754.1,null,null,null,null,null,null,0
[24252,null,null,null,0,null,null,4404.8,null,0,0,null,null,null,0,null,null,6754.1,null,null,null,null,null,null,0
[null,7544.9,37597.4,37597.4,null,39256.1,37597.4,null,0,null,null,0,1831.7,37597.4,null,0,37691.8,null,37597.4,37597.4,37597.4,37597.4,0,37597.4,null
[null,6651.4,36703.9,36703.9,null,38362.6,36703.9,null,1790.1,null,null,1790.1,0,36703.9,null,1790.1,36798.3,null,36703.9,36703.9,36703.9,36703.9,1790.1,36703.9,null
[null,41668.4,0,0,null,4013.8,0,null,37580.5,null,null,37580.5,36724.6,0,null,37580.5,1555.8,null,0,0,0,0,37580.5,0,null
[24252,null,null,null,0,null,null,4404.8,null,0,0,null,null,null,0,null,null,6754.1,null,null,null,null,null,null,0
[null,7544.9,37597.4,37597.4,null,39256.1,37597.4,null,0,null,null,0,1831.7,37597.4,null,0,37691.8,null,37597.4,37597.4,37597.4,37597.4,0,37597.4,null
[null,41817.7,1477.5,1477.5,null,3753.5,1477.5,null,37729.8,null,null,37729.8,36873.9,1477.5,null,37729.8,0,null,1477.5,1477.5,1477.5,1477.5,37729.8,1477.5,null
[17497.9,null,null,null,6754.1,null,null,2349.3,null,6754.1,6754.1,null,null,null,6754.1,null,null,0,null,null,null,null,null,null,6754.1
[null,41668.4,0,0,null,4013.8,0,null,37580.5,null,null,37580.5,36724.6,0,null,37580.5,1555.8,null,0,0,0,0,37580.5,0,null
[null,41668.4,0,0,null,4013.8,0,null,37580.5,null,null,37580.5,36724.6,0,null,37580.5,1555.8,null,0,0,0,0,37580.5,0,null
[null,41668.4,0,0,null,4013.8,0,null,37580.5,null,null,37580.5,36724.6,0,null,37580.5,1555.8,null,0,0,0,0,37580.5,0,null
[null,41668.4,0,0,null,4013.8,0,null,37580.5,null,null,37580.5,36724.6,0,null,37580.5,1555.8,null,0,0,0,0,37580.5,0,null
[null,7544.9,37597.4,37597.4,null,39256.1,37597.4,null,0,null,null,0,1831.7,37597.4,null,0,37691.8,null,37597.4,37597.4,37597.4,37597.4,0,37597.4,null
[null,41668.4,0,0,null,4013.8,0,null,37580.5,null,null,37580.5,36724.6,0,null,37580.5,1555.8,null,0,0,0,0,37580.5,0,null
[24252,null,null,null,0,null,null,4404.8,null,0,0,null,null,null,0,null,null,6754.1,null,null,null,null,null,null,0]
```

Contributor guide

Open the contributing guide

Research direction

Start at the getMatrix entry point in mapbox-sdk-js and reproduce the request with the supplied locations and profile. Compare the master response with the npm version and inspect how the matrix response is handled. Done means the same request no longer produces unexpected null values, with the expected behavior verified against the reproduced output.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.