mapbox / mapbox/mapbox-scenekit
Combine separate latitude, longitude arguments into CLLocationCoordinate2D
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 232
- Forks
- 50
- PR merge metrics
- No merged PRs in 30d
Description
This library separates latitude and longitude into separate arguments or properties in many places. There is a strong convention on Apple platforms of using CLLocationCoordinate2D or CLLocation whenever possible to represent geographic coordinate pairs.
Some of the antipatterns below would be addressed by #7:
https://github.com/mapbox/mapbox-scenekit/blob/1969fee0de7bc314098550c67bcd32d086ec289b/MapboxSceneKit/MapboxImageAPI.swift#L100
https://github.com/mapbox/mapbox-scenekit/blob/1969fee0de7bc314098550c67bcd32d086ec289b/MapboxSceneKit/Tile%20Fetching/MapboxHTTPAPI.swift#L47
https://github.com/mapbox/mapbox-scenekit/blob/1969fee0de7bc314098550c67bcd32d086ec289b/MapboxSceneKit/TerrainNode.swift#L16-L24
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the cited locations in MapboxImageAPI.swift, Tile Fetching/MapboxHTTPAPI.swift, and TerrainNode.swift, then compare their scope with issue #7. Identify the separate latitude and longitude arguments or properties that remain in scope. Done means applicable geographic coordinate pairs use CLLocationCoordinate2D or CLLocation consistently without duplicating work covered by #7.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100