mapbox / mapbox/mapbox-navigation-ios

Switch to night style when Smart Invert Colors is enabled

Open
#539 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

jira-sync-complete topic: accessibility
Dominant language
Swift
Stars
918
Forks
326
Avg merge
1h 16m
Merged PRs (30d)
3

Description

NavigationMapView should automatically switch to the night style when the Smart Invert Colors option is enabled in iOS 11, based on UIAccessibilityIsInvertColorsEnabled() or the UIAccessibilityInvertColorsStatusDidChange notification. It’s possible that UIKit will take care of inverting the UI correctly when Smart Invert Colors is enabled, but we’d still need to choose the opposite style.

/ref https://github.com/mapbox/mapbox-navigation-ios/issues/423#issuecomment-324851696
/cc @ericrwolfe @frederoni @bsudekum

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at NavigationMapView and inspect how it selects its current style. Read the UIAccessibilityIsInvertColorsEnabled() API and the UIAccessibilityInvertColorsStatusDidChange notification referenced in the issue. Done means the map automatically selects the opposite style when Smart Invert Colors is enabled or changes state.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.