mapbox / mapbox/mapbox-navigation-ios

Implement snapshot tests for `StyleManager`.

Open
#3,968 0 comments 0 reactions 1 assignee View on GitHub

@MaximAlien is already working on this.

Since Jun 24, 2022.

improvement jira-sync-complete op-ex UI
Dominant language
Swift
Stars
918
Forks
326
Avg merge
1h 16m
Merged PRs (30d)
3

Description

At this point there are multiple issues related to styling while using both iOS and CarPlay. One of the major issues is described in: https://github.com/mapbox/mapbox-navigation-ios/issues/3917.

There are already several tests in StyleManagerTests, but they do not verify whether actual style was applied correctly and doesn't interfere with other components.

In scope of this ticket snapshot tests for StyleManager should be implemented. Main components that should be tested here are:

  • NavigationViewController
  • CarPlayMapViewController
  • CarPlayNavigationViewController

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.