mapbox / mapbox/mapbox-navigation-ios

Show waypoint at target coordinate

Open
#3,892 0 comments 0 reactions 1 assignee View on GitHub

@MaximAlien is already working on this.

Since May 26, 2022.

bug :beetle: jira-sync-complete topic: directions UI
Dominant language
Swift
Stars
918
Forks
326
Avg merge
1h 16m
Merged PRs (30d)
3

Description

`NavigationMapView.showWaypoints(on:legIndex:)` always annotates `Waypoint.coordinate`, even if that coordinate is merely a “routable point” from the Mapbox Geocoding API that represents the nearest point on the road network, rather than the specific destination the user wanted to reach. This method should prefer `Waypoint.targetCoordinate` over `Waypoint.coordinate` if set.

https://github.com/mapbox/mapbox-navigation-ios/blob/111551d3a31740505d20da45b0f897fd979def38/Sources/MapboxNavigation/NavigationMapView.swift#L1145

/cc @mapbox/navigation-ios

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.