mapbox / mapbox/mapbox-navigation-ios
Disabled tests tracking
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 918
- Forks
- 326
- Avg merge
- 1h 16m
- Merged PRs (30d)
- 3
Description
Right now we have the following tests disabled:
- [ ] `MapboxCoreNavigationTests.testArrive()`, it fails on CI but run well locally
- [ ] `NavigationEventsManagerTests.testDepartRerouteArrive()`
- [ ] `NavigationServiceTests.testLocationShouldUseHeading()`, it's broken by `PortableRoutecontroller` & `MBNavigator`
- [ ] `DataCacheTests.testCacheKeyPerformance()`, `InstructionPresenterTests.testAbbreviationPerformance()` and `StepsViewControllerTests.testUpdateCellPerformance()`, tracked in [#1468](https://github.com/mapbox/mapbox-navigation-ios/issues/1468)
- [x] `NavigationMapViewTests.testHighlightBuildings()` and `NavigationViewControllerTests.testPuck3DLayerPosition()`, the failures are related with the `MapboxMaps` upgrade ([#3790](https://github.com/mapbox/mapbox-navigation-ios/issues/3790)).
/cc @mapbox/navigation-ios @MaximAlien
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the listed disabled tests: MapboxCoreNavigationTests.testArrive(), NavigationEventsManagerTests.testDepartRerouteArrive(), NavigationServiceTests.testLocationShouldUseHeading(), and the performance tests. Run them on CI and locally, then review issues #1468 and #3790 for the tracked failures. Done means the relevant tests pass and are no longer disabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile-dev, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100