mapbox / mapbox/mapbox-navigation-ios
Remove `CarPlayManagerDelegate.carPlayManagerDidEndNavigation(_:)` delegate method.
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 918
- Forks
- 326
- Avg merge
- 1h 16m
- Merged PRs (30d)
- 3
Description
Since `CarPlayManagerDelegate.carPlayManagerDidEndNavigation(_:)` was replaced by `CarPlayManagerDelegate.carPlayManagerDidEndNavigation(_:byCanceling:)` but couldn't be deprecated/obsoleted because of various issues described in this [comment](https://github.com/mapbox/mapbox-navigation-ios/pull/3731/files#r802161994) it'll have to be removed in next major release.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the CarPlayManagerDelegate declaration and its implementations or call sites for carPlayManagerDidEndNavigation(_:). Use the linked pull-request comment for the compatibility context, then remove the old delegate method and verify that only carPlayManagerDidEndNavigation(_:byCanceling:) remains for the next major release.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile-dev
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100