mapbox / mapbox/mapbox-navigation-ios

Fix flaky tests in MapboxCoreNavigation

Open
#3,667 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Core jira-sync-complete op-ex
Dominant language
Swift
Stars
918
Forks
326
Avg merge
1h 16m
Merged PRs (30d)
3

Description

Several tests have been failing on CircleCI during initial push, then succeed when rerun. We should disable them until we have a fix.

Tests are:
```
BillingHandlerUnitTests.testTripPerWaypoint()
BillingHandlerUnitTests.testTripPerWaypoint()
PassiveLocationManagerTests.testManualLocations()
RouteControllerTests.testRerouteAfterArrival()
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the named tests in the MapboxCoreNavigation test suite and inspect how they are run on CircleCI, starting with the failing initial push reports. Disable the listed flaky tests and verify that the test run no longer executes them while the remaining suite passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile-dev, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.