mapbox / mapbox/mapbox-navigation-ios

State of injected `NavigationMapView` should be reverted to the original one after finishing active navigation.

Open
#3,576 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

jira-sync-complete UI
Dominant language
Swift
Stars
918
Forks
326
Avg merge
1h 16m
Merged PRs (30d)
3

Description

While injecting NavigationMapView to the NavigationViewController several of its properties will be irrevocably modified. It'll lead to undefined behavior while invoking camera updates, calling delegate methods etc.

In scope of this ticket state saving mechanism should be implemented, which allows to revert back to original state of NavigationMapView (the one which was used prior to injection).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how NavigationMapView is injected into NavigationViewController and identify which properties are modified during that process. Define completion as restoring the original NavigationMapView state after active navigation finishes, including behavior relevant to camera updates and delegate methods.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.