mapbox / mapbox/mapbox-navigation-ios
CarPlayNavigationViewController and RouteController should share location manager
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 918
- Forks
- 326
- Avg merge
- 1h 16m
- Merged PRs (30d)
- 3
Description
CarPlayNavigationViewController and RouteController own two independent location managers. NavigationService doesn’t have the ability to respond to two different location managers at the same time, so #3393 has to keep the two location managers in sync, selectively shielding one from notifications meant for the other. CarPlayNavigationViewController should share a location manager with RouteController, just like the two classes share a NavigationService.
/ref https://github.com/mapbox/mapbox-navigation-ios/pull/3393#discussion_r732090388
/cc @mapbox/navigation-ios
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating CarPlayNavigationViewController and RouteController, then read how each owns its location manager and how both share NavigationService. Review the discussion in PR #3393 for the synchronization context. Done means both controllers use one shared location manager without the notification shielding described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100