mapbox / mapbox/mapbox-navigation-ios
Display generic icon for roundabout instruction without heading
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 918
- Forks
- 326
- Avg merge
- 1h 16m
- Merged PRs (30d)
- 3
Description
OSRM-based profiles of the Directions API apparently leave the `degrees` property of a banner instruction object unset if the leg ends on the roundabout (avoiding an exit roundabout maneuver). When this happens, we should display a slight right turn arrow (slight left turn in left-side-driving countries) to suggest entering a roundabout without saying exactly how far to go within the roundabout.
This heuristic is unnecessary for Valhalla-based profiles, which provide a heading. It also doesn’t apply to routes that exit the roundabout; in that case, all profiles provide a heading.
/ref mapbox/mapbox-navigation-android#3867
/cc @mapbox/navigation-ios @Guardiola31337 @pjleonard37
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by locating the iOS banner instruction handling for roundabouts and the unset `degrees` case; verify the generic slight-turn arrow, its left-side-driving variant, and that routes exiting the roundabout and Valhalla-based profiles remain unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100