mapbox / mapbox/mapbox-navigation-ios
Make EndOfRouteViewController public and reusable
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 918
- Forks
- 326
- Avg merge
- 1h 16m
- Merged PRs (30d)
- 3
Description
EndOfRouteViewController is a private class. We should expose it publicly and make it more reusable, similar to FeedbackViewController, so that the application can more easily solicit feedback about a trip after ending the trip. As it is, the user must complete the trip in order to access this view controller, but if they quit the application or it crashes, there’s no way for the user to explain why. This is somewhat a platform parity issue, because the Android navigation SDK apparently decouples feedback events from arrival events, which is what would probably need to happen when making EndOfRouteViewController reusable in this way.
/cc @mapbox/navigation-ios
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating EndOfRouteViewController and comparing it with FeedbackViewController. Determine how arrival and feedback events are coupled, then define a reusable public flow that can solicit trip feedback even when the trip ends through quitting or a crash; done should provide feedback access independently of arrival.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100