mapbox / mapbox/mapbox-navigation-ios
Use speed limit from NavNative in turn-by-turn navigation
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 918
- Forks
- 326
- Avg merge
- 1h 16m
- Merged PRs (30d)
- 3
Description
Right now in the active navigation we use the speed limit from the Directions response: https://github.com/mapbox/mapbox-navigation-ios/blob/89708651afae2e98ec774d7d2e00c7773aa87fcc/Sources/MapboxCoreNavigation/RouteLegProgress.swift#L209-L236
It's better to migrate to the values returned by NavNative, because they may contain speed limits from the route graph even if the Directions response is missing these values.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Sources/MapboxCoreNavigation/RouteLegProgress.swift, especially lines 209-236, to trace how the active navigation currently obtains the speed limit. Read the NavNative speed-limit values and determine the integration point. Done means active navigation uses NavNative values, including when the Directions response lacks a speed limit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100