mapbox / mapbox/mapbox-navigation-ios
Casing is incorrectly drawn for vanishing route line with intermediate waypoint.
@MaximAlien is already working on this.
Since Nov 19, 2020.
- Dominant language
- Swift
- Stars
- 918
- Forks
- 326
- Avg merge
- 1h 16m
- Merged PRs (30d)
- 3
Description
**Mapbox Navigation SDK version:** `main`
After reverting back `NavigationMapView.shape(forCasingOf:legIndex:)` in https://github.com/mapbox/mapbox-navigation-ios/pull/2623 main route casing for vanishing route line is no longer in sync during active-guidance navigation. For example:
@Udumft, @1ec5 I think you mentioned that there are clients that still use this method. Would you be able to describe it in more detail? When I look at current implementation of `NavigationMapView.shape(forCasingOf:legIndex:)` here:
https://github.com/mapbox/mapbox-navigation-ios/blob/829a91c87ebdce876dd0f906467ebaa8693ca14c/MapboxNavigation/NavigationMapView.swift#L1206-L1221
it seems that its implementation should be similar to `NavigationMapView.shape(for:legIndex:)`.
/cc @mapbox/navigation-ios @1ec5 @Udumft
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.