mapbox / mapbox/mapbox-navigation-ios
Avoid compiler error when built on unrecognized architecture
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 918
- Forks
- 326
- Avg merge
- 1h 16m
- Merged PRs (30d)
- 3
Description
The user agent string construction code should accommodate unrecognized architectures for consistency with mapbox/mapbox-directions-swift#486 and mapbox/mapbox-speech-swift#41:
https://github.com/mapbox/mapbox-navigation-ios/blob/9295eb949904ef79c5fe1b72c45ed40d2e70605b/MapboxCoreNavigation/URLSession.swift#L26-L51
/cc @mapbox/navigation-ios @gwynne
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect MapboxCoreNavigation/URLSession.swift at lines 26-51, then compare the analogous changes referenced in mapbox-directions-swift#486 and mapbox-speech-swift#41. The work is done when user-agent construction builds successfully for unrecognized architectures while remaining consistent with those implementations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100