mapbox / mapbox/mapbox-navigation-ios
Route overview excludes destination pin
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 918
- Forks
- 326
- Avg merge
- 1h 16m
- Merged PRs (30d)
- 3
Description
The logic for fitting the route to the map preview doesn’t account for the fact that the destination pin extends above the destination coordinate. There needs to be some additional top padding as long as the destination is toward the north. The issue is mitigated somewhat by the padding applied on all sides.
Seen in CarPlay route preview but probably also reproducible in route overview in both the phone and CarPlay.
/ref #2211
/cc @mapbox/navigation-ios
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the route overview in CarPlay with a destination north of the route, then compare the route bounds with the destination pin. Check whether the same behavior occurs in the phone and CarPlay previews. Done means the destination pin is included without extra padding when the destination is not toward the north, with the existing all-sides padding preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100