mapbox / mapbox/mapbox-navigation-ios
Move user notifications out of NavigationViewController
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 918
- Forks
- 326
- Avg merge
- 1h 16m
- Merged PRs (30d)
- 3
Description
NavigationViewController is currently responsible for creating and scheduling user notifications (push notifications) on the lock screen that are synchronized with spoken instructions. We should move the user notification functionality into its own component so that applications with custom UIs don’t have to roll their own user notifications.
This would also be a good opportunity to make user notifications optional: #1957.
/cc @mapbox/navigation-ios @d-prukop
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing user notification creation and scheduling in NavigationViewController, then review issue #1957 for the optional-notification requirement. Identify the responsibilities that must move into a standalone component and how custom-UI applications would use it. Done means notification functionality is reusable outside the existing controller and can be disabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100