mapbox / mapbox/mapbox-navigation-ios
CarPlayManager should be initializable with an options object
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 918
- Forks
- 326
- Avg merge
- 1h 16m
- Merged PRs (30d)
- 3
Description
#1951 added a NavigationOptions class to consolidate the various arguments that were previously passed into the NavigationViewController initializer. CarPlayManager should accept an instance of a similar class or even the same class. There may be some overlap between the options that the NavigationViewController and CarPlayManager can support. Perhaps this would be an opportunity to replace NavigationOptions with a protocol and have NavigationViewControllerOptions and CarPlayManagerOptions coexist with names that are harder to confuse with NavigationRouteOptions.
CarPlayNavigationViewController might benefit from something similar if there’s a valid reason for a developer to initialize one themselves.
/ref https://github.com/mapbox/mapbox-navigation-ios/pull/1951#discussion_r252907735 #2045
/cc @mapbox/navigation-ios
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing NavigationOptions from PR #1951 and the initializers for CarPlayManager, NavigationViewController, and CarPlayNavigationViewController. Decide whether to share an options type or define separate options protocols/classes, then confirm which initializers should accept them and document the completed API decision.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100