mapbox / mapbox/mapbox-navigation-ios
Enable developers to set/adjust the volume of spoken instructions
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 918
- Forks
- 326
- Avg merge
- 1h 16m
- Merged PRs (30d)
- 3
Description
It should be possible for developers to easily set the volume of spoken instructions during turn-by-turn navigation. Unfortunately this may be more complicated than it seems as the SDK adaptively switches between a media player and the built-in TTS system depending on network and other conditions.
Ideally we could address #1826 , but at least we should make it possible to set the volume programmatically so that developers can control this and/or expose it to their users for finer-grained control.
We have [some code](https://github.com/mapbox/mapbox-navigation-ios/blob/481c800e70eb4c15e6dc36fbc32922eb2a8c6d7b/MapboxNavigation/MapboxVoiceController.swift#L47) in place which appears to be trying to do this, but I don't think it is working as expected. Therefore I've also marked this as a bug.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in MapboxNavigation/MapboxVoiceController.swift around line 47 and inspect how spoken instructions switch between the media player and built-in TTS. Reproduce the volume behavior and trace both playback paths. Done means developers can set the spoken-instruction volume programmatically and the setting works regardless of which playback system is active.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100