mapbox / mapbox/mapbox-navigation-android

PR #7654 merged without successful status checks (mapbox-navigation-android)

Open
#7,657 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
651
Forks
321
PR merge metrics
No merged PRs in 30d

Description

:wave: Hey there! It's [Changebot](https://github.com/mapbox/changebot), and I help repositories follow our [engineering](https://github.com/mapbox/engineering) best practices. My magic wand found some things I wanted to highlight for your review:

Item | Current status | Required? | Best practice guidelines
--- | --- | --- | ---
Run unsuccessful: [ci/circleci: release-workflow/release-snapshot-start](https://circleci.com/workflow-run/9f549679-b905-4138-845e-2750eb414d5b) | pending | optional | success
Run unsuccessful: [ci/circleci: default/mobile-metrics-dry-run](https://circleci.com/workflow-run/3c07b5f1-0745-436c-8248-47cdf0a48556) | pending | optional | success
Run unsuccessful: [process](https://github.com/mapbox/mapbox-navigation-android/actions/runs/7140777539/job/19446734903) | skipped | optional | success
Run unsuccessful: [publisher-deployer](https://github.com/mapbox/mapbox-navigation-android/runs/19446734747) | neutral | optional | success
Run unsuccessful: [default](https://github.com/mapbox/mapbox-navigation-android/runs/19446734199) | null | optional | success
Run unsuccessful: [release-workflow](https://github.com/mapbox/mapbox-navigation-android/runs/19446734075) | null | optional | success

The following PR was merged without the status checks passing: https://github.com/mapbox/mapbox-navigation-android/pull/7654

Can you take a look at these best practices and make any adjustments if needed?

Please tag `@mapbox/security-and-compliance` on this issue if you have any questions

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review merged PR #7654 and the listed release-workflow, default, process, publisher-deployer, and mobile-metrics-dry-run checks, starting with the linked CircleCI and GitHub Actions runs. Compare their pending, skipped, neutral, and null results with the linked engineering best practices; done means the required merge safeguards prevent a PR from merging without successful status checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.