mapbox / mapbox/mapbox-navigation-android
PR #7579 merged without successful status checks (mapbox-navigation-android)
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 651
- Forks
- 321
- PR merge metrics
- No merged PRs in 30d
Description
:wave: Hey there! It's [Changebot](https://github.com/mapbox/changebot), and I help repositories follow our [engineering](https://github.com/mapbox/engineering) best practices. My magic wand found some things I wanted to highlight for your review:
Item | Current status | Required? | Best practice guidelines
--- | --- | --- | ---
Run unsuccessful: [ci/circleci: release-workflow/release-snapshot-start](https://circleci.com/workflow-run/89b8090c-7df0-4bd5-809d-567ae0717e54) | pending | optional | success
Run unsuccessful: [ci/circleci: default/mobile-metrics-dry-run](https://circleci.com/workflow-run/eb575f1d-0da1-4987-acdc-d41144cc5933) | pending | optional | success
Run unsuccessful: [process](https://github.com/mapbox/mapbox-navigation-android/actions/runs/6639626264/job/18038366799) | skipped | optional | success
Run unsuccessful: [codecov/project](https://github.com/mapbox/mapbox-navigation-android/runs/17971772536) | failure | optional | success
Run unsuccessful: [publisher-deployer](https://github.com/mapbox/mapbox-navigation-android/runs/17970368819) | neutral | optional | success
Run unsuccessful: [default](https://github.com/mapbox/mapbox-navigation-android/runs/17970367190) | null | optional | success
Run unsuccessful: [release-workflow](https://github.com/mapbox/mapbox-navigation-android/runs/17970366961) | null | optional | success
The following PR was merged without the status checks passing: https://github.com/mapbox/mapbox-navigation-android/pull/7579
Can you take a look at these best practices and make any adjustments if needed?
Please tag `@mapbox/security-and-compliance` on this issue if you have any questions
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review PR #7579 and the linked CircleCI and GitHub Actions runs to determine why the merge proceeded with unsuccessful checks. Compare the repository's merge and status-check behavior with the linked engineering best practices; done means required checks prevent a merge unless they pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, kotlin
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100