mapbox / mapbox/mapbox-navigation-android
PR #7576 merged without successful status checks (mapbox-navigation-android)
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 651
- Forks
- 321
- PR merge metrics
- No merged PRs in 30d
Description
:wave: Hey there! It's [Changebot](https://github.com/mapbox/changebot), and I help repositories follow our [engineering](https://github.com/mapbox/engineering) best practices. My magic wand found some things I wanted to highlight for your review:
Item | Current status | Required? | Best practice guidelines
--- | --- | --- | ---
Run unsuccessful: [ci/circleci: release-workflow/release-snapshot-start](https://circleci.com/workflow-run/f6a0fe16-1d66-4325-8f5d-93f03cbd8aee) | pending | optional | success
Run unsuccessful: [default](https://github.com/mapbox/mapbox-navigation-android/runs/17890450454) | null | optional | success
Run unsuccessful: [process](https://github.com/mapbox/mapbox-navigation-android/actions/runs/6576512779/job/17866095653) | skipped | optional | success
Run unsuccessful: [process](https://github.com/mapbox/mapbox-navigation-android/actions/runs/6576512759/job/17866095047) | skipped | optional | success
Run unsuccessful: [process](https://github.com/mapbox/mapbox-navigation-android/actions/runs/6576512756/job/17866094977) | skipped | optional | success
Run unsuccessful: [process](https://github.com/mapbox/mapbox-navigation-android/actions/runs/6576512749/job/17866094975) | skipped | optional | success
Run unsuccessful: [publisher-deployer](https://github.com/mapbox/mapbox-navigation-android/runs/17864654912) | neutral | optional | success
Run unsuccessful: [release-workflow](https://github.com/mapbox/mapbox-navigation-android/runs/17864654109) | null | optional | success
The following PR was merged without the status checks passing: https://github.com/mapbox/mapbox-navigation-android/pull/7576
Can you take a look at these best practices and make any adjustments if needed?
Please tag `@mapbox/security-and-compliance` on this issue if you have any questions
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review PR #7576 and the listed CircleCI and GitHub Actions runs to determine why unsuccessful optional checks allowed the merge. Start with the linked workflow runs and the repository's engineering best-practice guidelines. Done means the relevant status checks enforce the expected success behavior and a comparable PR cannot merge with unsuccessful checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100