mapbox / mapbox/mapbox-navigation-android
PR #7541 merged without successful status checks (mapbox-navigation-android)
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 651
- Forks
- 321
- PR merge metrics
- No merged PRs in 30d
Description
:wave: Hey there! It's [Changebot](https://github.com/mapbox/changebot), and I help repositories follow our [engineering](https://github.com/mapbox/engineering) best practices. My magic wand found some things I wanted to highlight for your review:
Item | Current status | Required? | Best practice guidelines
--- | --- | --- | ---
Run unsuccessful: [ci/circleci: release-workflow/release-snapshot-start](https://circleci.com/workflow-run/f5f30c89-e58b-4a00-9203-9311aba49c06) | pending | optional | success
Run unsuccessful: [ci/circleci: default/mobile-metrics-dry-run](https://circleci.com/workflow-run/d681a9f7-b9d9-45ae-824f-3221227e6011) | pending | optional | success
Run unsuccessful: [ci/circleci: ui-robo-tests](https://circleci.com/gh/mapbox/mapbox-navigation-android/150489) | pending | optional | success
Run unsuccessful: [publisher-deployer](https://github.com/mapbox/mapbox-navigation-android/runs/17469593810) | neutral | optional | success
Run unsuccessful: [default](https://github.com/mapbox/mapbox-navigation-android/runs/17469592988) | null | optional | success
Run unsuccessful: [release-workflow](https://github.com/mapbox/mapbox-navigation-android/runs/17469592770) | null | optional | success
The following PR was merged without the status checks passing: https://github.com/mapbox/mapbox-navigation-android/pull/7541
Can you take a look at these best practices and make any adjustments if needed?
Please tag `@mapbox/security-and-compliance` on this issue if you have any questions
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PR #7541 and the linked CircleCI and GitHub workflow runs to understand why pending, neutral, and null checks allowed the merge. Compare the repository's status-check configuration with the listed engineering best practices. Done means the cause is addressed and merges no longer bypass the intended successful checks.
Written by the indexing model from the issue text.
Assessment
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100