mapbox / mapbox/mapbox-navigation-android
[Android Auto] Allow `ActionStrip?` in `MapboxScreenActionStripProvider`
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 651
- Forks
- 321
- PR merge metrics
- No merged PRs in 30d
Description
`MapboxScreenActionStripProvider` was introduced in [this PR](https://github.com/mapbox/mapbox-navigation-android/pull/6681/files) with the aim of allowing customisation to 3rd party apps.
Right now it is not possible to return an empty list of Actions in the ActionStrip:
`java.lang.IllegalStateException: Action strip must contain at least one action`
A possibility would be allowing this interface to return `ActionStrip?` and handling the null case in the specific screen implementation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the introduction of MapboxScreenActionStripProvider in PR #6681 and trace its use in the specific Android Auto screen implementation. Confirm how a nullable ActionStrip should be handled when no actions are supplied; done means an empty action list no longer raises the Action strip must contain at least one action exception.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100